feat: store server_info on ClientSession after initialization#1935
Closed
kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
feat: store server_info on ClientSession after initialization#1935kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Adds `_server_info` field to ClientSession that gets populated during `initialize()` with the server's name and version from the response. This follows the existing pattern for `_server_capabilities` and lets clients access server info without manually extracting it from the init result. Closes modelcontextprotocol#1018
Author
|
Closing as superseded by #1954 which includes a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stores
server_infofrom the init response onClientSessionso you can grab the server's name and version without manually extracting from the result.Changes
_server_infofield toClientSession.__init__result.server_infoduringinitialize()get_server_info()getter (mirrors existingget_server_capabilities())Before
After
Testing
test_get_server_infocovering None-before-init and populated-afterCloses #1018